Skip to content

Always user unique cache key#1773

Merged
MartinRiese merged 2 commits into
masterfrom
riese/rm_cache_key_ff
May 12, 2026
Merged

Always user unique cache key#1773
MartinRiese merged 2 commits into
masterfrom
riese/rm_cache_key_ff

Conversation

@MartinRiese
Copy link
Copy Markdown
Contributor

@MartinRiese MartinRiese commented May 7, 2026

Product Description

Remove usage of cache key FF. Defaults to the FF behavior now.

Technical Summary

https://dimagi.atlassian.net/browse/USH-6540

Safety Assurance

FF has been released in production, enabling it for all projects. This just removes the check.

Safety story

Automated test coverage

Yes

QA Plan

None

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Remove usage of cache key FF
@MartinRiese MartinRiese marked this pull request as ready for review May 7, 2026 16:18
@MartinRiese MartinRiese requested review from esoergel and shubham1g5 May 7, 2026 16:18
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.08%. Comparing base (14f69ec) to head (48f1ba5).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1773      +/-   ##
============================================
- Coverage     70.10%   70.08%   -0.03%     
+ Complexity     2030     2027       -3     
============================================
  Files           257      257              
  Lines          8011     8005       -6     
  Branches        764      763       -1     
============================================
- Hits           5616     5610       -6     
  Misses         2112     2112              
  Partials        283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@esoergel esoergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicky comments, nothing breaking.

Comment thread src/test/java/org/commcare/formplayer/tests/CaseSearchResultsInStorageTests.java Outdated
* Update test name
@MartinRiese MartinRiese merged commit 51c35b3 into master May 12, 2026
6 of 7 checks passed
@MartinRiese MartinRiese deleted the riese/rm_cache_key_ff branch May 12, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants