Always user unique cache key#1773
Merged
Merged
Conversation
Remove usage of cache key FF
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1773 +/- ##
============================================
- Coverage 70.10% 70.08% -0.03%
+ Complexity 2030 2027 -3
============================================
Files 257 257
Lines 8011 8005 -6
Branches 764 763 -1
============================================
- Hits 5616 5610 -6
Misses 2112 2112
Partials 283 283 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
esoergel
approved these changes
May 12, 2026
Contributor
esoergel
left a comment
There was a problem hiding this comment.
A few nitpicky comments, nothing breaking.
* Update test name
esoergel
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
Remove usage of cache key FF. Defaults to the FF behavior now.
Technical Summary
https://dimagi.atlassian.net/browse/USH-6540
Safety Assurance
FF has been released in production, enabling it for all projects. This just removes the check.
Safety story
Automated test coverage
Yes
QA Plan
None
Rollback instructions
Review