-
-
Notifications
You must be signed in to change notification settings - Fork 302
Add joint_natural_frequency and joint_damping_ratio to GenericJoint. #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add joint_natural_frequency and joint_damping_ratio to GenericJoint. #789
Conversation
⚠️ I'm not sure about multibodies
src/dynamics/solver/joint_constraint/joint_generic_constraint.rs
Outdated
Show resolved
Hide resolved
…ion parameters, in favor of having them directly in GenericJoint
|
Can you clarify about the open question more?
I for one don't use multibodies right now, so I'm tempted to just merge this into my fork to test it, but other than that, does it introduce any issues? |
cfm_coeffandrhs_biascomputed fromjoint_natural_frequencyandjoint_damping_ratiois shared with all constraint solver methods, so we'd probably need a strategy to conciliate different values into one?