Fix unsound uses of get_unchecked_mut
#873
Open
+14
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple unsound uses of
get_unchecked_mut
.That function does not allow you to get multiple mutable references into a slice.
It only skips bounds-checking, nothing else.
You can run this code with
cargo miri run
to see the issue:Since
1.86
, stable Rust provides the exact functions you need:get_disjoint_mut
andget_disjoint_unchecked_mut
.Notes:
IndexMut2
Trait is redundant and should probably be removed.get_mut_with_parent
, I've kept the same error message for "Internal error: circular rigid body dependency. ", but that probably should just beget_disjoint_mut(..).unwrap()