Skip to content

Fix CGI.parse not found in Ruby 4 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kronenthaler wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix CGI.parse not found in Ruby 4 #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24f712a
fix issue with deprecated cgi.parse in ruby 4
kronenthaler Jan 5, 2026
3caca33
Update Ruby version to latest in workflow
kronenthaler Jan 5, 2026
64b6067
Update Ruby version in workflow to 3.4 and 4.0
kronenthaler Jan 5, 2026
bf5d330
fix unstable sort
kronenthaler Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: macos-latest
strategy:
matrix:
ruby-version: ['3.2.2']
ruby-version: ['3.4', '4.0']

steps:
- uses: actions/checkout@v3
Expand Down
12 changes: 6 additions & 6 deletions danger-xcode_summary.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,21 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 2.4.0'

spec.add_dependency 'danger-plugin-api', '~> 1.0'
spec.add_dependency 'xcresult', '~> 0.2.2'
spec.add_dependency 'xcresult'

# General ruby development
spec.add_development_dependency 'bundler', '>= 2.2.10'
spec.add_development_dependency 'rake', '~> 13.0'
spec.add_development_dependency 'rake'

# Testing support
spec.add_development_dependency 'rspec', '~> 3.4'
spec.add_development_dependency 'rspec'

# Makes testing easy via `bundle exec guard`
spec.add_development_dependency 'guard', '~> 2.14'
spec.add_development_dependency 'guard-rspec', '~> 4.7'
spec.add_development_dependency 'guard'
spec.add_development_dependency 'guard-rspec'

# If you want to work on older builds of ruby
spec.add_development_dependency 'listen', '~> 3.0'
spec.add_development_dependency 'listen'

# This gives you the chance to run a REPL inside your test
# via
Expand Down
2 changes: 1 addition & 1 deletion lib/xcode_summary/plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ def parse_location(document_location)
file_path = document_location.url.gsub('file://', '').split('#').first
file_name = file_path.split('/').last
fragment = document_location.url.split('#').last
params = CGI.parse(fragment).transform_values(&:first)
params = URI.decode_www_form(fragment).to_h
line_number = params['StartingLineNumber']
# StartingLineNumber is 0-based, but we need a 1-based value
line = line_number.nil? || line_number.empty? ? 0 : line_number.to_i + 1
Expand Down
2 changes: 1 addition & 1 deletion spec/xcode_summary_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ module Danger
context 'with sort_warnings_by' do
before do
@xcode_summary.sort_warnings_by do |warning|
warning.message.include?('TODOs') ? 0 : 1
"#{warning.message.include?('TODOs') ? 0 : 1}_#{warning&.location&.file_path}/#{warning&.location&.file_name}:#{warning&.location&.line}/"
end
end
it 'sorts compile warnings' do
Expand Down