Draft
Conversation
… Futures works correctly.
…rac-institute/kbmod-wf into issue/40/smaller-reproj-tasks
drewoldag
commented
Sep 10, 2024
Collaborator
Author
There was a problem hiding this comment.
If this PR is ultimately merged to main, we should delete this file. I only created it initially to ensure that using Futures in a specific way would not block the workflow. Specifically on line 217 of this file, the input for the next task is defined as [i.result() for i in list_of_futures].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This initial commit begins to assemble a workflow that will generate many small reprojection tasks that each ingest a single workunit shard for reprojection. This allows a task to use only 1 cpu and a small amount of memory instead of 32+ cpus and a large amount of memory.
A separate workflow has been created to support this approach in the file
parallel_repro_single_chip_wf.py. It makes use of a simplified reprojection, specifically using astropy'sreproject_adaptive. This approach is likely fine for the single night, single chip scenario, but is not generally correct in the case of either multiple chips, or images with identical timestamps.