Run sorcha without forcing reading config file or forced writing results to disk#1181
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 85.08% 84.87% -0.22%
==========================================
Files 69 69
Lines 3534 3557 +23
==========================================
+ Hits 3007 3019 +12
- Misses 527 538 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@yoachim The team needs to chat internally if we're happy for this to be setup for not running with config files. My worry is it's really easy to forget how you set things up if we allow this. We've also been making a lot of changes for Rubin operations so if we do agree to go this direction, this may PR may be better to be merged when we have the changes in for using real LSST pointing information. |
|
Our next call is February 9th. I'll raise this then @yoachim |
|
@mschwamb sounds good, no particular rush. My main pitch here is that I know astronomers love their config and csv files, but it's good practice to let python users call your python code from within python. And if code is going to run on a cluster it's important to give users control over disk I/O. If I've got 30 pointing histories and 7 solar system populations, I don't want 200+ jobs simultaneously trying to dump observations to disk (which I'm then just going to have to read back in and analyze anyway). |
adb1976 to
d652bf6
Compare
Little-Ryugu
left a comment
There was a problem hiding this comment.
Looks nearly good to go. Just a small addition to the docstrings to help future development, and you need to run black version 26.1.0 for the linter.
Little-Ryugu
left a comment
There was a problem hiding this comment.
Looks all good to me.
For cases where one has several pointing histories and several solar system body populations, it would be useful to loop over those within python and call
runLSSTSimulationdirectly without using the command line and configuration file(s).sorchaConfigsis now a subclass ofbasesorchaConfigs, so if one wants to make a config without reading a file it is possible to withbasesorchaConfigs, andsorchaConfigsbehaves as before.return_onlykwargs torunLSSTSimulationandPPStats.statsso users are not forced to write output to disk in case they just want the DataFrames returnedReview Checklist for Source Code Changes