Skip to content

fix: Narrow thread-related properties for channels #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Narrow thread-related properties for channels #1377

wants to merge 5 commits into from

Conversation

Nabil-249
Copy link

@Nabil-249 Nabil-249 commented Sep 21, 2025 •
edited
Loading

Narrows the property parent_id for:

  • APIThreadChannel: now includes parent_id?: Snowflake, reflecting its parent thread relationship.

  • APIGuildCategoryChannel: now includes parent_id?: null, clarifying that categories do not have a parent.

Narrows the property applied_tags for:

  • APIThreadOnlyChannel: now applied_tags: Snowflake[] is explicit to this type.

Reference: https://discord.com/developers/docs/resources/channel#channel-object-channel-structure

@vercel Vercel
Copy link

vercel bot commented Sep 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-api-types Ready Ready Preview Comment Sep 21, 2025 2:01pm

@Nabil-249 Nabil-249 closed this Sep 21, 2025
@Nabil-249
Copy link
Author

Nabil-249 commented Sep 21, 2025 •
edited
Loading

Forgot to update deno's types as well, will do it in the next draft will do a commit it here.

@Nabil-249 Nabil-249 reopened this Sep 21, 2025
@vladfrangu
Copy link
Member

Just run the script, it will do it for you

vladfrangu
vladfrangu previously requested changes Sep 21, 2025
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to do this change for v9, please 🙏

@Nabil-249
fix(Channel): fix type inference for APIChannel v9
313183f
@Nabil-249
fix(Channel): fix inference for applied_tags
41a2c3f 
only show applied_tags field in APIGuildForumChannel and APIGuildMediaChannel
@Nabil-249 Nabil-249 marked this pull request as ready for review September 21, 2025 13:26
@Nabil-249 Nabil-249 requested review from a team as code owners September 21, 2025 13:26
@vladfrangu
Copy link
Member

Please also run the formatting scripts :D

@Jiralite Jiralite changed the title fix(Channel): fix type inference for APIChannel fix: Narrow thread-related properties for channels Sep 21, 2025
@Nabil-249
Copy link
Author

Shall I bump the version in package.json as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
topic:payloads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nabil-249 @vladfrangu @Jiralite