feat(Interactions)!: member objects for uncached guilds

packages/discord.js/src/managers/GuildMemberRoleManager.js

@@ -34,7 +34,7 @@ class GuildMemberRoleManager extends DataManager {
    */
   get cache() {
     const everyone = this.guild.roles.everyone;
-    return this.guild.roles.cache.filter(role => this.member._roles.includes(role.id)).set(everyone.id, everyone);
+    return this.guild.roles.cache.filter(role => this.member.roleIds.includes(role.id)).set(everyone.id, everyone);
   }
 
   /**
@@ -133,7 +133,7 @@ class GuildMemberRoleManager extends DataManager {
       await this.client.rest.put(Routes.guildMemberRole(this.guild.id, this.member.id, roleOrRoles), { reason });
 
       const clone = this.member._clone();
-      clone._roles = [...this.cache.keys(), roleOrRoles];
+      clone.roleIds = [...this.cache.keys(), roleOrRoles];
       return clone;
     }
   }
@@ -173,7 +173,7 @@ class GuildMemberRoleManager extends DataManager {
 
       const clone = this.member._clone();
       const newRoles = this.cache.filter(role => role.id !== roleOrRoles);
-      clone._roles = [...newRoles.keys()];
+      clone.roleIds = [...newRoles.keys()];
       return clone;
     }
   }
@@ -200,7 +200,7 @@ class GuildMemberRoleManager extends DataManager {
 
   clone() {
     const clone = new this.constructor(this.member);
-    clone.member._roles = [...this.cache.keys()];
+    clone.member.roleIds = [...this.cache.keys()];
     return clone;
   }
 }

packages/discord.js/src/structures/BaseInteraction.js

@@ -4,6 +4,7 @@ const { Collection } = require('@discordjs/collection');
 const { DiscordSnowflake } = require('@sapphire/snowflake');
 const { InteractionType, ApplicationCommandType, ComponentType } = require('discord-api-types/v10');
 const Base = require('./Base');
+const MinimalGuildMember = require('./MinimalGuildMember');
 const { SelectMenuTypes } = require('../util/Constants');
 const PermissionsBitField = require('../util/PermissionsBitField');
 
@@ -62,9 +63,11 @@ class BaseInteraction extends Base {
 
     /**
      * If this interaction was sent in a guild, the member which sent it
-     * @type {?(GuildMember|APIInteractionGuildMember)}
+     * @type {?(GuildMember|MinimalGuildMember)}
      */
-    this.member = data.member ? (this.guild?.members._add(data.member) ?? data.member) : null;
+    this.member = data.member
+      ? (this.guild?.members._add(data.member) ?? new MinimalGuildMember(this.client, data.member, this.guildId))
+      : null;
 
     /**
      * The version

packages/discord.js/src/structures/CommandInteraction.js

@@ -3,6 +3,7 @@
 const Attachment = require('./Attachment');
 const BaseInteraction = require('./BaseInteraction');
 const InteractionWebhook = require('./InteractionWebhook');
+const MinimalGuildMember = require('./MinimalGuildMember');
 const InteractionResponses = require('./interfaces/InteractionResponses');
 
 /**
@@ -83,7 +84,7 @@ class CommandInteraction extends BaseInteraction {
    * Represents the resolved data of a received command interaction.
    * @typedef {Object} CommandInteractionResolvedData
    * @property {Collection<Snowflake, User>} [users] The resolved users
-   * @property {Collection<Snowflake, GuildMember|APIGuildMember>} [members] The resolved guild members
+   * @property {Collection<Snowflake, GuildMember|MinimalGuildMember>} [members] The resolved guild members
    * @property {Collection<Snowflake, Role|APIRole>} [roles] The resolved roles
    * @property {Collection<Snowflake, BaseChannel|APIChannel>} [channels] The resolved channels
    * @property {Collection<Snowflake, Message|APIMessage>} [messages] The resolved messages
@@ -102,7 +103,7 @@ class CommandInteraction extends BaseInteraction {
    * @property {CommandInteractionOption[]} [options] Additional options if this option is a
    * subcommand (group)
    * @property {User} [user] The resolved user
-   * @property {GuildMember|APIGuildMember} [member] The resolved member
+   * @property {GuildMember|MinimalGuildMember} [member] The resolved member
    * @property {GuildChannel|ThreadChannel|APIChannel} [channel] The resolved channel
    * @property {Role|APIRole} [role] The resolved role
    * @property {Attachment} [attachment] The resolved attachment
@@ -129,7 +130,11 @@ class CommandInteraction extends BaseInteraction {
       if (user) result.user = this.client.users._add(user);
 
       const member = resolved.members?.[option.value];
-      if (member) result.member = this.guild?.members._add({ user, ...member }) ?? member;
+      if (member) {
+        result.member =
+          this.guild?.members._add({ user, ...member }) ??
+          new MinimalGuildMember(this.client, { user, ...member }, this.guildId);
+      }
 
       const channel = resolved.channels?.[option.value];
       if (channel) result.channel = this.client.channels._add(channel, this.guild) ?? channel;

packages/discord.js/src/structures/CommandInteractionOptionResolver.js

@@ -214,7 +214,7 @@ class CommandInteractionOptionResolver {
   /**
    * Gets a member option.
    * @param {string} name The name of the option.
-   * @returns {?(GuildMember|APIGuildMember)}
+   * @returns {?(GuildMember|MinimalGuildMember)}
    * The value of the option, or null if the user is not present in the guild or the option is not set.
    */
   getMember(name) {
@@ -258,7 +258,7 @@ class CommandInteractionOptionResolver {
    * Gets a mentionable option.
    * @param {string} name The name of the option.
    * @param {boolean} [required=false] Whether to throw an error if the option is not found.
-   * @returns {?(User|GuildMember|APIGuildMember|Role|APIRole)}
+   * @returns {?(User|GuildMember|MinimalGuildMember|Role|APIRole)}
    * The value of the option, or null if not set and not required.
    */
   getMentionable(name, required = false) {