Skip to content

feat: Enforce limit of URLs for link buttons #11011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

feat: Enforce limit of URLs for link buttons #11011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/builders/__tests__/components/button.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Button Components', () => {
button.toJSON();
}).not.toThrowError();

expect(() => new LinkButtonBuilder().setURL('https://google.com')).not.toThrowError();
expect(() => new LinkButtonBuilder().setLabel('label').setURL('https://google.com').toJSON()).not.toThrowError();
});

test('GIVEN invalid fields THEN build does throw', () => {
Expand Down Expand Up @@ -61,6 +61,13 @@ describe('Button Components', () => {
expect(() => new PrimaryButtonBuilder().setCustomId('hi').setDisabled(0).toJSON()).toThrowError();
// @ts-expect-error: Invalid emoji
expect(() => new PrimaryButtonBuilder().setCustomId('hi').setEmoji('foo').toJSON()).toThrowError();

expect(() =>
new LinkButtonBuilder()
.setLabel('label')
.setURL(`https://google.com/${'a'.repeat(512)}`)
.toJSON(),
).toThrowError();
});

test('GiVEN valid input THEN valid JSON outputs are given', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/builders/src/components/Assertions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const buttonDangerPredicate = buttonCustomIdPredicateBase.extend({ style: z.lite

const buttonLinkPredicate = buttonPredicateBase.extend({
style: z.literal(ButtonStyle.Link),
url: z.url({ protocol: /^(?:https?|discord)$/ }),
url: z.url({ protocol: /^(?:https?|discord)$/ }).max(512),
emoji: emojiPredicate.optional(),
label: labelPredicate,
});
Expand Down