feat(GuildMember): add 'clearTimeout' method #11020
Closed
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
I think it can be a good add. This method can make the code easier to read and a little bit more logic because call timeout function to remove the timeout is not very logic. |
didinele
reviewed
Aug 1, 2025
Yes, I didn't think about that. |
|
Closing for the reason listed above. This is generally why helper methods should be avoided. Regardless, thank you for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add
clearTimeoutmethod to guildMember.Actually, you have to set the duration on null to cancel the timeout of a guild member.
The clearTimeout method would make the code more easy to read.