Skip to content

perf(flamegraph): regenerate artifact after order-book/network changes#139

Merged
div0rce merged 1 commit into
mainfrom
perf/flamegraph-refresh-post-optimization
Jun 24, 2026
Merged

perf(flamegraph): regenerate artifact after order-book/network changes#139
div0rce merged 1 commit into
mainfrom
perf/flamegraph-refresh-post-optimization

Conversation

@div0rce

@div0rce div0rce commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

Refreshes the committed flamegraph so its Source digest matches the current src//include/ after this session's merged changes (#136 decoder validation, #137 network hardening, #138 try_emplace). Dirty inputs: no, ~20k samples, zero [unknown] frames.

What it shows

The try_emplace optimization (#138) is visible in the profile: the previously top-3 std::_Rb_tree::_M_emplace_unique allocation frame (~1137 samples — the redundant price-level map node alloc/free) is gone from the hot stacks. The hot path is now the actual matching work — cancel, match_baseline, rest, new_limit — rather than allocation overhead.

Notes

  • Artifact-only change (results/flamegraph.svg + .txt); no code changes.
  • Regenerated on the bare-metal Apple M2 Fedora Asahi host via make flamegraph; Source digest (not the commit hash) is the artifact identity.

🤖 Generated with Claude Code

Refreshes the committed flamegraph so its Source digest matches current src/
(PRs #136 #137 #138; Dirty inputs: no). The try_emplace optimization (#138) is
visible: the previously top-3 std::_Rb_tree::_M_emplace_unique allocation frame
(~1137 samples) is gone from the hot stacks, which are now the actual matching
work — cancel, match_baseline, rest, new_limit. ~20k samples, zero [unknown].

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@div0rce, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 10 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 83d21688-3799-47bf-847d-fe9ce1e72881

📥 Commits

Reviewing files that changed from the base of the PR and between 1094c84 and da3f0f3.

⛔ Files ignored due to path filters (1)
  • results/flamegraph.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • results/flamegraph.txt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/flamegraph-refresh-post-optimization

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@div0rce div0rce merged commit d42e59c into main Jun 24, 2026
8 checks passed
@div0rce div0rce deleted the perf/flamegraph-refresh-post-optimization branch June 24, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant