Type hints/toolbar #2227
Open
Type hints/toolbar #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tim-schilling @matthiask I suggest we start using https://github.com/typeddjango/django-stubs for the typing |
Comment on lines
+52
to
+61
| # Use OrderedDict for the _panels attribute so that items can be efficiently | ||
| # removed using FIFO order in the DebugToolbar.store() method. The .popitem() | ||
| # method of Python's built-in dict only supports LIFO removal. | ||
| # type: ignore[var-annotated] | ||
| self._panels = OrderedDict() | ||
| while panels: | ||
| panel = panels.pop() | ||
| self._panels[panel.panel_id] = panel | ||
| self.stats: dict[str, Any] = {} | ||
| self.server_timing_stats: dict[str, Any] = {} |
There was a problem hiding this comment.
This feels like there may have been a merge conflict issue.
| return getattr(self.request, "csp_nonce", None) | ||
|
|
||
| def get_panel_by_id(self, panel_id): | ||
| def get_panel_by_id(self, panel_id: str) -> "Panel": |
There was a problem hiding this comment.
Sorry, I'm likely missing something basic. Why can't we use -> Panel since we have the TYPE_CHECKING import check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds type hints to the middleware and toolbar modules. It's based on the work of @leandrodesouzadev in this pr #1848
Fixes #1705
Checklist:
docs/changes.rst.