Skip to content

add setting PROMETHEUS_TOTAL_BYTES_BUCKETS for metric body size #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add setting PROMETHEUS_TOTAL_BYTES_BUCKETS for metric body size #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions django_prometheus/conf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from django.conf import settings
from django_prometheus.utils import PowersOf

NAMESPACE = ""

Expand All @@ -22,6 +23,9 @@
float("inf"),
)

PROMETHEUS_TOTAL_BYTES_BUCKETS = PowersOf(2, 30)

if settings.configured:
NAMESPACE = getattr(settings, "PROMETHEUS_METRIC_NAMESPACE", NAMESPACE)
PROMETHEUS_LATENCY_BUCKETS = getattr(settings, "PROMETHEUS_LATENCY_BUCKETS", PROMETHEUS_LATENCY_BUCKETS)
PROMETHEUS_TOTAL_BYTES_BUCKETS = getattr(settings, "PROMETHEUS_TOTAL_BYTES_BUCKETS", PROMETHEUS_TOTAL_BYTES_BUCKETS)
8 changes: 4 additions & 4 deletions django_prometheus/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from django.utils.deprecation import MiddlewareMixin
from prometheus_client import Counter, Histogram

from django_prometheus.conf import NAMESPACE, PROMETHEUS_LATENCY_BUCKETS
from django_prometheus.utils import PowersOf, Time, TimeSince
from django_prometheus.conf import NAMESPACE, PROMETHEUS_LATENCY_BUCKETS, PROMETHEUS_TOTAL_BYTES_BUCKETS
from django_prometheus.utils import Time, TimeSince


class Metrics:
Expand Down Expand Up @@ -96,7 +96,7 @@ def register(self):
Histogram,
"django_http_requests_body_total_bytes",
"Histogram of requests by body size.",
buckets=PowersOf(2, 30),
buckets=PROMETHEUS_TOTAL_BYTES_BUCKETS,
namespace=NAMESPACE,
)
# Set in process_template_response
Expand Down Expand Up @@ -126,7 +126,7 @@ def register(self):
Histogram,
"django_http_responses_body_total_bytes",
"Histogram of responses by body size.",
buckets=PowersOf(2, 30),
buckets=PROMETHEUS_TOTAL_BYTES_BUCKETS,
namespace=NAMESPACE,
)
self.responses_by_charset = self.register_metric(
Expand Down