Skip to content

Conversation

cunla
Copy link
Member

@cunla cunla commented Aug 18, 2025

  • New member issue has a checkbox "Do you want to join to the designers team?"
  • terraform creates a designers team based on designers variable in org.tfvars
  • add_member.py takes team_name so a member can be added to both members list and designers list.

@cunla cunla requested a review from a team as a code owner August 18, 2025 12:59
Copy link

github-actions bot commented Aug 18, 2025

Terraform plan in terraform
With var files: terraform/production/org.tfvars terraform/production/repositories.tfvars
With variables: github_token = (sensitive value)

Plan: 2 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # github_team.org_designers_team will be created
+   resource "github_team" "org_designers_team" {
+       create_default_maintainer = false
+       description               = "Django Commons designers"
+       etag                      = (known after apply)
+       id                        = (known after apply)
+       members_count             = (known after apply)
+       name                      = "Designers"
+       node_id                   = (known after apply)
+       parent_team_read_id       = (known after apply)
+       parent_team_read_slug     = (known after apply)
+       privacy                   = "closed"
+       slug                      = (known after apply)
    }

  # github_team_members.org_designers_team_members will be created
+   resource "github_team_members" "org_designers_team_members" {
+       id      = (known after apply)
+       team_id = (known after apply)

+       members {
+           role     = "member"
+           username = "SmitK"
        }
+       members {
+           role     = "member"
+           username = "akshayvinchurkar"
        }
+       members {
+           role     = "member"
+           username = "mzemlickis"
        }
+       members {
+           role     = "member"
+           username = "viscofuse"
        }
    }

Plan: 2 to add, 0 to change, 0 to destroy.

📝 Plan generated in Plan org changes and list them in a PR #142

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think there's a bug in the add designer step of the GHA, but I could be wrong.

@tim-schilling tim-schilling merged commit b2e29fc into main Sep 6, 2025
2 checks passed
@tim-schilling tim-schilling deleted the designers-team branch September 6, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants