Skip to content

Conversation

@sarahboyce
Copy link
Contributor

Fixes #2349

I also added playwright to have a way to test JavaScript (might be controversial and can remove if wanted)
This is an alternative to #2355. Here, only one search bar exists in the page

@sarahboyce sarahboyce marked this pull request as ready for review January 7, 2026 14:00
@sarahboyce sarahboyce requested review from SaptakS and adamzap January 7, 2026 14:01
Copy link
Member

@adamzap adamzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, @sarahboyce! This is the kind of solution I was hoping for.

We should confirm that this design change on wide viewports is intended and ideal:

Before:

Image

After:

Image

I think it's a nice improvement!

I'll take a closer look at the Playwright integration.

</nav>
<div class="header-tools">
{% search_form %}
{% include "includes/toggle_theme.html" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could remove this include now, but it's probably out of scope here.

@sarahboyce
Copy link
Contributor Author

We should confirm that this design change on wide viewports is intended [...]
I think it's a nice improvement!

It wasn't intentional, I also think I prefer it to the current state. I know ülgen pointed out in the slack group that prior to the previous navbar change the navbar was centered on wide viewpoints. So perhaps we can chose what we want and make some adjustments 👍

@adamzap
Copy link
Member

adamzap commented Jan 8, 2026

@sarahboyce We discussed this PR in the WG meeting today. Could you move the Playwright parts of this to another PR so that we can iterate on front-end testing separately?

@sarahboyce
Copy link
Contributor Author

Could you move the Playwright parts of this to another PR so that we can iterate on front-end testing separately?

Moved to #2444

@sarahboyce sarahboyce requested a review from adamzap January 9, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hotkey for focus-on-search broken

2 participants