Full switch to scikit-build-core #124
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an in-progress switch to using
scikit-build-corefor the build system.As of now, I've just added (untested) bindings in cpp for nanobind. I've done this by switching numerical pointers to ndarray types, and then just calling
.data()on those new types to get the underlying pointers to the arrays. I'm sure that this can be simplified in the c code, but this is just meant to be as low effort of a switch as possible.Next would be to fix the python interface to use these bindings correctly, and to set up
scikit-build-coreas a build dependency.