fix(core): replace unwrap() with error handling, add missing tests#9
Merged
lostmygithubaccount merged 1 commit intomainfrom Apr 4, 2026
Merged
fix(core): replace unwrap() with error handling, add missing tests#9lostmygithubaccount merged 1 commit intomainfrom
lostmygithubaccount merged 1 commit intomainfrom
Conversation
…g tests Replace two unwrap() calls in config.rs (rename_alias, delete_alias) with context-rich error propagation. Add 6 new Python tests covering alias/group operations and error cases. Fix bin/test consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unwrap()calls inconfig.rs(rename_alias,delete_alias) withcontext()-based error propagationrename_alias,delete_alias,rename_group,delete_group,delete_url_not_found,rename_url_collisionbin/testfor consistency with other scriptsReview notes
unwrap()calls inbookmarks-appare safe (guarded by precedingifchecks on the sameOption) — left as-iscore.pyi) are complete — no changes needed🤖 Generated with Claude Code