#433: Add basic set of JUnit tests for Data- and TimeMachine component #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- closes #433 - fixes bug/glitch in DataMachineFiles#line99 - fixes bug/glitch in TimeMachineFiles#line49 - removes spammy, oldskool FileMemoryLogger from default ILogger config in AbstractEnvironmentFactory as the same behavior (log 'files') can be achieved via some external config
There was a problem hiding this comment.
Pull request overview
This PR adds JUnit tests for DataMachine and TimeMachine components, fixes two bugs in copy/error handling, and removes the FileMemoryLogger from default logging configuration.
Changes:
- Adds comprehensive JUnit test suites for DataMachine and TimeMachine factory and domain classes
- Fixes critical bug in TimeMachineFiles copy constructor where pageLinksFile was incorrectly assigned metaHistoryFile value
- Fixes bug in DataMachineFiles where error message referenced wrong variable
- Updates Slf4JLogger to log Throwables at error level instead of info level
- Removes FileMemoryLogger from default ILogger configuration in AbstractEnvironmentFactory
- Adds input validation and defensive null checks in Files and DataMachineFiles
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| dkpro-jwpl-wikimachine/src/main/java/org/dkpro/jwpl/wikimachine/factory/AbstractEnvironmentFactory.java | Removes FileMemoryLogger from default logger configuration, adds explanatory comment |
| dkpro-jwpl-wikimachine/src/main/java/org/dkpro/jwpl/wikimachine/domain/Files.java | Adds null/blank validation for setOutputDirectory with defensive behavior when path is not a directory |
| dkpro-jwpl-wikimachine/src/main/java/org/dkpro/jwpl/wikimachine/debug/Slf4JLogger.java | Changes Throwable logging from info to error level |
| dkpro-jwpl-timemachine/src/main/java/org/dkpro/jwpl/timemachine/domain/TimeMachineFiles.java | Fixes copy constructor bug, removes blank line in setTimestamp, improves formatting |
| dkpro-jwpl-datamachine/src/main/java/org/dkpro/jwpl/datamachine/domain/DataMachineFiles.java | Fixes error message to reference correct variable, adds null/blank validation, adds defensive null checks in getters |
| dkpro-jwpl-timemachine/src/test/java/org/dkpro/jwpl/timemachine/factory/DefaultTimeMachineEnvironmentFactoryTest.java | Adds factory tests verifying component instantiation |
| dkpro-jwpl-timemachine/src/test/java/org/dkpro/jwpl/timemachine/domain/TimeMachineFilesTest.java | Adds comprehensive tests for TimeMachineFiles including validation, getters, and copy constructor |
| dkpro-jwpl-datamachine/src/test/java/org/dkpro/jwpl/datamachine/factory/DefaultDataMachineEnvironmentFactoryTest.java | Adds factory tests verifying component instantiation |
| dkpro-jwpl-datamachine/src/test/java/org/dkpro/jwpl/datamachine/domain/DataMachineFilesTest.java | Adds comprehensive tests for DataMachineFiles including validation, getters, and copy constructor |
| dkpro-jwpl-timemachine/src/test/resources/log4j2.xml | Adds log4j2 configuration for test resources |
| dkpro-jwpl-datamachine/src/test/resources/log4j2.xml | Adds log4j2 configuration for test resources |
| dkpro-jwpl-datamachine/src/test/resources/log4j2.properties | Removes old log4j properties file |
| dkpro-jwpl-timemachine/src/test-e2e/java/org/dkpro/jwpl/timemachine/domain/JWPLTimeMachineE2ETest.java | Restructures directory organization for E2E tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...o-jwpl-timemachine/src/test/java/org/dkpro/jwpl/timemachine/domain/TimeMachineFilesTest.java
Outdated
Show resolved
Hide resolved
...o-jwpl-timemachine/src/test/java/org/dkpro/jwpl/timemachine/domain/TimeMachineFilesTest.java
Outdated
Show resolved
Hide resolved
...o-jwpl-datamachine/src/test/java/org/dkpro/jwpl/datamachine/domain/DataMachineFilesTest.java
Outdated
Show resolved
Hide resolved
...o-jwpl-datamachine/src/test/java/org/dkpro/jwpl/datamachine/domain/DataMachineFilesTest.java
Outdated
Show resolved
Hide resolved
...o-jwpl-datamachine/src/test/java/org/dkpro/jwpl/datamachine/domain/DataMachineFilesTest.java
Outdated
Show resolved
Hide resolved
dkpro-jwpl-wikimachine/src/main/java/org/dkpro/jwpl/wikimachine/domain/Files.java
Outdated
Show resolved
Hide resolved
...o-jwpl-timemachine/src/test/java/org/dkpro/jwpl/timemachine/domain/TimeMachineFilesTest.java
Outdated
Show resolved
Hide resolved
rzo1
reviewed
Jan 17, 2026
dkpro-jwpl-timemachine/src/main/java/org/dkpro/jwpl/timemachine/domain/TimeMachineFiles.java
Show resolved
Hide resolved
rzo1
approved these changes
Jan 17, 2026
- addresses AI-driven quality checks
mawiesne
deleted the
433-Add-basic-set-of-JUnit-tests-for-Data--and-TimeMachine-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
mvn clean verify -Ptest-e2e-toolsAutomatic testing
Documentation