feat(keybindings): add Author variable for PR and issue commands #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlvhdr
reviewed
Jan 19, 2026
internal/tui/ui_test.go
Outdated
| require.Empty(t, sections, "sections should be empty when repo is nil") | ||
| } | ||
|
|
||
| func TestPRTemplateVariables(t *testing.T) { |
Owner
There was a problem hiding this comment.
I don't think these tests actually do anything :S
Contributor
Author
There was a problem hiding this comment.
I don't think these tests actually do anything :S
They’re testing that Go’s struct field access works! 😆
But yeah, I guess I kinda should make them test more than just that, probably. I will give it a try.
Contributor
Author
There was a problem hiding this comment.
OK, added some tests that actually test what they should be testing…
sideshowbarker
force-pushed
the
author-variable
branch
3 times, most recently
from
35b60b7 to
0f144cc
Compare
This change exposes a PR/Issue author's GH username as {{.Author}} in
custom keybinding command templates.
That allows you to do things like this in your dash config file:
keybindings:
prs:
- key: P
command: open https://github.com/{{.Author}}
In other words: you can, e.g., configure a key which — when you press it
while you have a particular PR/issue selected in a dashboard in dash —
will open their GH profile page in a browser.
sideshowbarker
force-pushed
the
author-variable
branch
from
0f144cc to
3bf7d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change exposes a PR/Issue author’s GH username as
{{.Author}}in custom keybinding command templates.That allows you to do things like this in your dash config file:
In other words: you can, e.g., configure a key which — when you press it while you have a particular PR/issue selected in a dashboard in dash — will open their GH profile page in a browser.
How did you test this change?
Added tests to: