Open
Conversation
dmippolitov
reviewed
Dec 27, 2020
| ns: the nameserver IP to use for direct lookup | ||
| """ | ||
| self.host = host | ||
| self.ns = ns |
Owner
There was a problem hiding this comment.
As i understand there is no effect of specifying ns for Provider in the scope of this PR?
Author
There was a problem hiding this comment.
Yes, this was used in other code not included.
Owner
There was a problem hiding this comment.
I still cant figure out how ns affects resolver
dmippolitov
reviewed
Jan 2, 2023
| else: | ||
| self._loop = loop | ||
| self._resolver = aiodns.DNSResolver(timeout=timeout, tries=tries, loop=self._loop) | ||
| self._resolver = aiodns.DNSResolver(timeout=timeout, tries=tries, loop=self._loop, nameservers=ns) |
Owner
There was a problem hiding this comment.
This is fine, but there is questions on the other part of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Radically faster than using a local resolver in most cases.
Note: this should really be set per-provider, but looks like the minimal change is just to pass through to the resolver class.