Fix build with latest rmm. #11930
Open
Fix build with latest rmm. #11930
+64
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
nightly-rmm
branch
from
e93728d to
19107b8
Compare
Collaborator
|
We need to fix the logic for detecting the latest RMM. Right now, it uses |
Collaborator
|
@trivialfis Is this ready for review? |
Member
Author
|
Not yet. |
trivialfis
changed the title
Member
Author
|
@hcho3 The PR is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also need NVIDIA/cccl#7246 to have a clean build. I prefer using the MR as a member variable instead of asking RMM to lookup a map for every alloc/dealloc. Will followup on this one.