Java: fix timeout calculation and minor code clean-up #15
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpstotz for brevity’s sake would you mind stripping away the other edits? if not, I should be able to prune them out and merge the timer update. |
|
@dmsnell I have updated my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java
System.currentTimeMillis()returns the time of the system real-time clock which can change at any time, e.g. if your NTP client adjusts it. If this happens while a diff is running the timeout may increase or decrease in an undeterministic way.For this reason time calculation in Java should always use
System.nanoTime()which usually bases on the monotonic increasing tick counter of the CPU (see System.nanoTime() JavaDoc)The other edits are just minor code clean-up.