Add configurable ads volume control feature#366
Open
vivektiwari1986 wants to merge 3 commits intodmunozv04:mainfrom
Open
Add configurable ads volume control feature#366vivektiwari1986 wants to merge 3 commits intodmunozv04:mainfrom
vivektiwari1986 wants to merge 3 commits intodmunozv04:mainfrom
Conversation
Owner
|
Hi there, thanks for the PR! I'll look it more into detail when I get some time, but I'm wondering how it's able to know the original volume if |
Author
|
You are right. Setting on ad start will cause a eventType - onVolumeChanged and change it again. I ll add a original_pre_ads_volume that is set before ad star action. I posted this PR for early feedback. Planning to run a test on my apple tv and lg tv app today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option that allows users to set a specific volume level for YouTube ads instead of only having the option to completely mute them. Addresses #344
User Experience
Technical Implementation