fix(android): reject stale shell backlog + always-visible keyboard toggle#178
Open
wahaj4311 wants to merge 1 commit into
Open
fix(android): reject stale shell backlog + always-visible keyboard toggle#178wahaj4311 wants to merge 1 commit into
wahaj4311 wants to merge 1 commit into
Conversation
…ggle Terminal was broken on every reconnect with 'v1-Backend: terminal JSON-RPC stream closed' and the on-screen keyboard could not be summoned by tapping the viewport. Two fixes: 1. shared/remote_alleycat: reject replayed backlog frames from a prior killed shell session until our own shell/spawn returns and sets the expected session id. Otherwise a stale shell/exit in the ring breaks the read loop before initialize returns. 2. android/GhosttySurfaceView + TerminalScreen: pop the IME on every confirmed tap (previously the tap handler bailed out when the renderer was still binding), and add an explicit keyboard IconButton to the terminal header for reconnects/edge cases where focus is not restored to the SurfaceView.
cad0p
added a commit
to cad0p/litter
that referenced
this pull request
Jul 9, 2026
The com.apple.developer.carplay-voice-based-conversation entitlement requires special Apple approval and is not available via the public App Store Connect API capability list. Forks without that approval cannot build a TestFlight IPA. Remove it — CarPlay is not needed to test the terminal stale-backlog fix (PR dnakov#178).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pairs with dnakov/alleycat#PR (server-side session-replay fix for the shell agent). Either patch alone fixes the reconnect breakage; both together are the belt-and-suspenders.
Test plan