fix: upload dist artifact before signing for clean PyPI publish - #18
Merged
Conversation
…ublish Move upload-artifact step to right after build, before Cosign signing adds .sig and .pem files to dist/. The PyPI publish action only accepts valid Python distributions (.whl, .tar.gz). Signed-off-by: Igor Racic <iracic82@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
upload-artifactstep to right afterpython -m build, before Cosign signing adds.sigand.pemfiles todist/. The PyPI publish action only accepts valid Python distributions (.whl,.tar.gz) and fails on signature files.What happened
The v0.6.3 release workflow failed at the PyPI publish step:
Fix
Upload the dist artifact before signing, so only
.whland.tar.gzare included.Signed-off-by: Igor Racic iracic82@gmail.com