Normalize column names when filtering them #6918
Conversation
This fixes Table::getColumns not returning columns in their documented order (PK > FK > rest). Fixes doctrine#4158
| self::assertSame($columns[2], $orderedColumns[0]); | ||
| self::assertSame($columns[1], $orderedColumns[1]); | ||
| self::assertSame($columns[0], $orderedColumns[2]); |
There was a problem hiding this comment.
I'm sorry, these assertions are impossible to comprehend. What are you trying to achieve?
Regardless, the behavior of returning table columns in a non-natural order was deprecated in #4789 and removed in #4777. Instead of relying on the behavior that's going to change during the upgrade, you may want to make your code not rely on the deprecated behavior.
There was a problem hiding this comment.
My goal was to fix the inconsistent behavior seen in #4158
But I guess that will become moot if the (bugged) ordering is removed altogether 🤔
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
This fixes Table::getColumns not returning columns in their documented order (PK > FK > rest).
Fixes #4158