Fix Symfony 8 compatibility issues #7009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
changed the title
morozov
reviewed
Jun 18, 2025
| use Symfony\Component\Console\Output\OutputInterface; | ||
|
|
||
| if ((new ReflectionMethod(Command::class, 'execute'))->hasReturnType()) { | ||
| // Symfony 8 |
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Not yet, Symfony 8 is still a moving target until November.
| { | ||
| protected function configure(): void | ||
| { | ||
| $this->doConfigure(); |
Member
There was a problem hiding this comment.
Do we want to add a CI job to get this branch covered?
Member
Author
There was a problem hiding this comment.
Yeah, that's probably a good idea. I'll do it.
Member
Author
There was a problem hiding this comment.
I've changed our existing dev dependencies workflow. It now runs on PHP 8.4 and with Symfony 8 libraries.
derrabus
force-pushed
the
bugfix/symfony-8-compat
branch
2 times, most recently
from
e94e95f to
6aa049c
Compare
derrabus
force-pushed
the
bugfix/symfony-8-compat
branch
from
6aa049c to
5649126
Compare
morozov
approved these changes
Jul 21, 2025
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 26, 2025
* 3.10.x: Fix Symfony 8 compatibility issues (doctrine#7009)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 26, 2025
* 4.4.x: Document the JSON_OBJECT type (doctrine#7054) [RFC] Introduce Types::JSON_OBJECT (doctrine#7053) feat: add more pdo jobs with stringify fetches (doctrine#7052) Fix case sensitivity in SQLite column types (doctrine#7050) Fix length type in `MySQLSchemaManager` with `ATTR_STRINGIFY_FETCHES` enabled (doctrine#7028) Fix Symfony 8 compatibility issues (doctrine#7009) Quote MySQL constraint names for foreign keys
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Jul 27, 2025
* 4.4.x: Document the JSON_OBJECT type (doctrine#7054) [RFC] Introduce Types::JSON_OBJECT (doctrine#7053) feat: add more pdo jobs with stringify fetches (doctrine#7052) Fix case sensitivity in SQLite column types (doctrine#7050) Fix length type in `MySQLSchemaManager` with `ATTR_STRINGIFY_FETCHES` enabled (doctrine#7028) Fix Symfony 8 compatibility issues (doctrine#7009) Quote MySQL constraint names for foreign keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all current compatibility issues with Symfony 8.