Deprecate "service" connection parameter #7042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the current behavior is explicitly documented, it looks nonsensical to me. If I specify the
servicename
parameter in connection configuration but don't addservice = true
, instead of being interpreted asSERVICE_NAME
,servicename
will be interpreted asSID
:Technically, the addition of
|| isset($params['servicename'])
might be considered a BC break (servicename
which was previously interpreted asSID
will be interpreted asSERVICE_NAME
), but I'd consider it a bug fix. If the user expects that the connection will useSID
, they can usedbname
.In the short future, I want to deprecate the usage of
dbname
for Oracle connections in favor of introducing an explicitsid
parameter. The "database" term is too vague in the context of Oracle.