Quote Oracle user password #7043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DBAL, when building a
CREATE USERstatement, uses the password as is w/o any escaping. This way, it will fail to create the user if the password contains special characters. For example:Per the documentation,
Which documents the common quoting rules:
Which basically means that we need to quote the password:
In my understanding, unlike other database objects, passwords are always case-sensitive, even if declared as unquoted. So it's not a breaking change. Furthermore, I very much doubt that this method is used for anything else than testing (the method creates a new user with the same password as the password of the current user).