Fix introspection on PDO_pgsql with PDO::STRINGIFY_FETCHES enabled
#7052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@derrabus would love your review on this one as well ;) The postgres job already uncovered similar issues like the MySQL one we ran into For the other tests I personally think it is ok to just skip them for that specific job as it seems they cover some edge cases anyway and only run for specific drivers & configs |
derrabus
requested changes
Jul 22, 2025
Member
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
Thank you again! So the Postgres driver will also fail if we have that option enabled, am I right? We should treat this PR as a bugfix then.
Contributor
Author
@derrabus Yes exactly, IMHO this should be treated as a bugfix |
derrabus
approved these changes
Jul 24, 2025
derrabus
changed the title
PDO::STRINGIFY_FETCHES enabled
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 26, 2025
* 4.4.x: Document the JSON_OBJECT type (doctrine#7054) [RFC] Introduce Types::JSON_OBJECT (doctrine#7053) feat: add more pdo jobs with stringify fetches (doctrine#7052) Fix case sensitivity in SQLite column types (doctrine#7050) Fix length type in `MySQLSchemaManager` with `ATTR_STRINGIFY_FETCHES` enabled (doctrine#7028) Fix Symfony 8 compatibility issues (doctrine#7009) Quote MySQL constraint names for foreign keys
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Jul 27, 2025
* 4.4.x: Document the JSON_OBJECT type (doctrine#7054) [RFC] Introduce Types::JSON_OBJECT (doctrine#7053) feat: add more pdo jobs with stringify fetches (doctrine#7052) Fix case sensitivity in SQLite column types (doctrine#7050) Fix length type in `MySQLSchemaManager` with `ATTR_STRINGIFY_FETCHES` enabled (doctrine#7028) Fix Symfony 8 compatibility issues (doctrine#7009) Quote MySQL constraint names for foreign keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more unit test jobs that use the PDO::STRINGIFY_FETCHES option, as discussed in this PR: #7028 (review)
I didn't add a job for
pdo_ociandpdo_sqlsrvas for those drivers the result inQueryBuilderTestwas already stringified, therefore I assume those drivers always stringify the fetches, therefore a separate job is not needed