feat: add touch support #376
Conversation
|
I had a better look. Scrolling wouldn't work with this. Apparently So I guess I have to implement it myself. This makes the whole thing less trivial, because now we need to check if it's a tap or a drag, then selectively either propagate or block the event and finally move the scroll by |
TimP4w
force-pushed
the
touch-support
branch
2 times, most recently
from
465c6e1 to
77a57ef
Compare
|
Hey, thank you so much for your contribution! I have little time to review, but It will be my top priority <3 |
domferr
force-pushed
the
v17.0
branch
2 times, most recently
from
0266a31 to
8b7dd00
Compare
TimP4w
force-pushed
the
touch-support
branch
2 times, most recently
from
8c15e38 to
5860a7b
Compare
|
Changed base branch to v17.1 to aim to get this feature in the upcoming release! |
…r#373) * feat: use gnome accent color as default for window border color * preserve previous border color set and improve user settings * Disable the setting if accent colors are not supported * enable only on GNOME 47+ --------- Co-authored-by: Domenico Ferraro <[email protected]>
|
Great work, thank you! I have refactored the code, ensuring it works on GNOME versions from 42 to 49. I also improved the strategy, by reacting to touch events instead of emitting button press event (which was failing on GNOME 44). Unfortunately I cannot test the scrolling on my GNOME 44, since scrollView.vadjustment is not available. If I test with a virtual machine, touch events are propagated as button press/release events and I cannot test properly |
|
@TimP4w I will merge this PR, however can you double check everything is working on your side? Thank you! |
|
@domferr I'm a bit busy at the moment, but I'll try to test it on my laptop by the end of the week (GNOME 48) |
|
Thank you @TimP4w ! |
|
@domferr I tested it and it does not work... neither the click (select a window) nor the scroll. Also I believe there is a bug now, since the scrollbar is visible |
6 participants
Resolves #353