DOM-75891 replace get_job with get_job_or_404, require dataset_id in request definitions#62
Merged
Merged
Conversation
…re dataset_id in request definitions
niole
changed the title
| Unless I already specified that something should be optional, assume that when making new functions, every argument is | ||
| required. | ||
|
|
||
| When implementing code changes, if you start implementing a giant code diff you should stop and run your changes by me first. |
Collaborator
There was a problem hiding this comment.
i've had to tell it this many times in whatever project im working in, even if it's already saved as a memory
Collaborator
Author
There was a problem hiding this comment.
Yeah it can really dig itself into a hole. it's hard to develop in a completely black box way with these things
ddl-ryan-connor
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA https://dominodatalab.atlassian.net/browse/DOM-75891
This PR fixes almost all remaining un-authorized paths. It uses get_job_or_404 at the entry level for routes or services depending on which retrieves the first job. It also requires dataset_id in requests coming into the app so that we can't hit paths that retrieve data from the filesystem. THis is both a bug fix and an auth fix.
I filed another ticket for fixing something that appears to be an issue with resolve notebook data https://dominodatalab.atlassian.net/browse/DOM-76328