Open
Conversation
…t b21e6839e git-subtree-dir: src/Microsoft.DotNet.XUnitV3Assert/src git-subtree-split: b21e6839ee4ba6a426fac087f9421e13f2bd5dd4
…soft.DotNet.XUnitV3Assert/src'
akoeplinger
reviewed
Mar 2, 2026
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
do we really need to keep a separate copy or could we refresh our sources in Microsoft.DotNet.XUnitAssert ?
| <PackageVersion Include="Polly.Core" Version="8.4.1" /> | ||
| <PackageVersion Include="sn" Version="1.0.0" /> | ||
| <PackageVersion Include="xunit" Version="$(XUnitVersion)" /> | ||
| <PackageVersion Include="xunit.v3.core" Version="$(XUnitV3Version)" /> |
Member
There was a problem hiding this comment.
nit: move next to xunit.v3.extensibility.core
|
|
||
| This copy of assert.xunit is intended to be AOT-compatible and contains breaking changes from the | ||
| original code. In general, code which relied on reflection or dynamic code generation has been | ||
| removed in this fork. |
Member
There was a problem hiding this comment.
I diffed the sources with upstream assert.xunit and it was identical, so I assume we don't have breaking changes in the v3 version?
| @@ -0,0 +1,22 @@ | |||
| namespace Xunit.Internal | |||
| { | |||
| internal static class EnvironmentVariables | |||
Member
There was a problem hiding this comment.
this isn't in upstream assert.xunit, should we file an issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the equivalent of the Microsoft.Dotnet.XunitAssert package, except for one thing: this one uses the built-in AOT-compatibility from upsteam xunit.