[WIP] Trying to filter what tests run based on PR contents#65565
Draft
BrennanConroy wants to merge 11 commits intomainfrom
Draft
[WIP] Trying to filter what tests run based on PR contents#65565BrennanConroy wants to merge 11 commits intomainfrom
BrennanConroy wants to merge 11 commits intomainfrom
Conversation
github-actions
bot
added
the
area-infrastructure
Contributor
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
BrennanConroy
force-pushed
the
brecon/selectivetesting
branch
from
794eac3 to
7c5296c
Compare
The build step generates files in the source tree, causing subsequent git diff to detect additional changed areas. This leads to the helix step including test projects (Framework, JSInterop) that weren't restored by the build step, causing NETSDK1004 errors. Fix: Write the computed areas to artifacts/tmp/AffectedTestAreas.txt on first computation, then subsequent build steps reuse the cached result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
build.cmd uses 'PowerShell' (WinPS 5.1), where Join-Path only accepts 2 positional parameters. Three-argument Join-Path requires PS 6+. Nested Join-Path calls work in both PS 5.1 and 7+. Verified locally under PowerShell 5.1 with StrictMode and ErrorActionPreference Stop. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.