Skip to content

Remove redundant options logging in Azure storage providers #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
+8 −8
Merged

Remove redundant options logging in Azure storage providers #9807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ private async Task Init(CancellationToken ct)

try
{
LogInformationInitializing(this.options);
LogDebugInitializing(this.name, this.options.ContainerName);
if (options.CreateClient is not { } createClient)
{
throw new OrleansConfigurationException($"No credentials specified. Use the {options.GetType().Name}.{nameof(AzureBlobStorageOptions.ConfigureBlobServiceClient)} method to configure the Azure Blob Service client.");
Expand Down Expand Up @@ -365,11 +365,11 @@ private async Task Init(CancellationToken ct)
private partial void LogTraceContainerNotFound(string grainType, GrainId grainId, string? eTag, string blobName, string containerName);

[LoggerMessage(
Level = LogLevel.Information,
Level = LogLevel.Debug,
EventId = (int)AzureProviderErrorCode.AzureTableProvider_InitProvider,
Message = "AzureBlobGrainStorage initializing: {Options}"
Message = "AzureBlobGrainStorage {Name} is initializing: ContainerName={ContainerName}"
)]
private partial void LogInformationInitializing(AzureBlobStorageOptions options);
private partial void LogDebugInitializing(string name, string containerName);

[LoggerMessage(
Level = LogLevel.Information,
Expand Down
8 changes: 4 additions & 4 deletions src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureTableStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ private async Task Init(CancellationToken ct)
var stopWatch = Stopwatch.StartNew();
try
{
LogInfoStorageInitializing(name, this.options);
LogDebugStorageInitializing(name, this.options.TableName);
this.tableDataManager = new GrainStateTableDataManager(this.options, this.logger);
await this.tableDataManager.InitTableAsync();
stopWatch.Stop();
Expand Down Expand Up @@ -566,10 +566,10 @@ public void Participate(ISiloLifecycle lifecycle)

[LoggerMessage(
EventId = (int)AzureProviderErrorCode.AzureTableProvider_InitProvider,
Level = LogLevel.Information,
Message = "AzureTableGrainStorage {ProviderName} initializing: {Options}"
Level = LogLevel.Debug,
Message = "AzureTableGrainStorage {ProviderName} is initializing: TableName={TableName}"
)]
private partial void LogInfoStorageInitializing(string providerName, AzureTableStorageOptions options);
private partial void LogDebugStorageInitializing(string providerName, string tableName);

[LoggerMessage(
EventId = (int)AzureProviderErrorCode.AzureTableProvider_InitProvider,
Expand Down