Improve compiler error recovery for null coalesce assignment operator #80907
+654
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
AlekseyTs
reviewed
Oct 27, 2025
| if (leftOperand.HasAnyErrors || rightOperand.HasAnyErrors) | ||
| TypeSymbol leftType = leftOperand.Type; | ||
|
|
||
| var rightOperandTargetType = leftType switch |
AlekseyTs
reviewed
Oct 27, 2025
| var rightOperandTargetType = leftType switch | ||
| { | ||
| { IsReferenceType: true } or { IsValueType: false, TypeKind: TypeKind.TypeParameter } => leftType, | ||
| { IsValueType: true } when leftType.IsNullableType() => leftType.GetNullableUnderlyingType(), |
AlekseyTs
reviewed
Oct 27, 2025
| else if (rightOperand.HasAnyErrors) | ||
| { | ||
| leftOperand = BindToTypeForErrorRecovery(leftOperand); | ||
| var conversion = GenerateConversionForAssignment(rightOperandTargetType, rightOperand, diagnostics, ConversionForAssignmentFlags.CompoundAssignment); |
AlekseyTs
reviewed
Oct 27, 2025
| else if (rightOperand.HasAnyErrors) | ||
| { | ||
| leftOperand = BindToTypeForErrorRecovery(leftOperand); | ||
| var conversion = GenerateConversionForAssignment(rightOperandTargetType, rightOperand, diagnostics, ConversionForAssignmentFlags.CompoundAssignment); |
|
Done with review pass (commit 1), nests were not looked at. It looks like the change affects scenarios that fall outside of the stated goal of this PR. I suggest making adjustments to affect only error scenarios with target typed |
AlekseyTs
reviewed
Oct 27, 2025
| else if (rightOperand.HasAnyErrors) | ||
| { | ||
| leftOperand = BindToTypeForErrorRecovery(leftOperand); | ||
| var conversion = GenerateConversionForAssignment(rightOperandTargetType, rightOperand, diagnostics, ConversionForAssignmentFlags.CompoundAssignment); |
AlekseyTs
reviewed
Oct 27, 2025
| { | ||
| leftOperand = BindToTypeForErrorRecovery(leftOperand); | ||
| var conversion = GenerateConversionForAssignment(rightOperandTargetType, rightOperand, diagnostics, ConversionForAssignmentFlags.CompoundAssignment); | ||
| return new BoundNullCoalescingAssignmentOperator(node, leftOperand, conversion, rightOperandTargetType, hasErrors: true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #74218
Related to #73894