Let tuple/anonymous member name inference see through null suppression operator #80908
+143
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
AlekseyTs
reviewed
Oct 27, 2025
| continue; | ||
|
|
||
| case SyntaxKind.SuppressNullableWarningExpression: | ||
| input = ((PostfixUnaryExpressionSyntax)input).Operand; |
There was a problem hiding this comment.
It looks like this potentially can introduce a breaking change for an existing code. Let's add test(s) demonstrating that. And also let's document the breaking change. Once that is done, we can start an internal process for approving the breaking change.
AlekseyTs
reviewed
Oct 27, 2025
| } | ||
|
|
||
| [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/80752")] | ||
| public void ElementNameInference_FromLocal_NullSuppression() |
|
Done with review pass (commit 2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #80752
As I side effect, this also changed how membe name inference works for anonymous types as well. Declaring them with null suppression still errors, but the compiler guesses the most likely intended name. I don't think this is a bad side effect