Support for Wi-Fi/802.11 related radiotap fields: MCS, HE, VHT #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerkerolofsson
commented
Mar 6, 2024
jerkerolofsson
commented
- Support for Wi-Fi/802.11 related radiotap fields: MCS, HE, VHT. Reference: https://www.radiotap.org/fields/defined
- Added file header
- Add parsing of VeryHighThroughput radio tap field
PhyxionNL
requested changes
Mar 6, 2024
| Assert.AreEqual(field.PartialAid, recreatedField.PartialAid); | ||
| } | ||
|
|
||
| [Test] |
Comment on lines
8
to
10
| /* | ||
| * Copyright 2010 Chris Morgan <[email protected]> | ||
| */ |
Collaborator
There was a problem hiding this comment.
You can remove this bit from all files you've added.
Comment on lines
58
to
59
|
|
||
|
|
| public override ushort Length => 12; | ||
|
|
||
| /// <summary> | ||
| /// |
Collaborator
There was a problem hiding this comment.
Fix comments throughout file please.
| /// </summary> | ||
| public RadioTapMcsFlags Flags { get; set; } | ||
|
|
||
| public byte Mcs { get; set; } |
Comment on lines
294
to
295
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Formatting, best reformat this entire file.
added 2 commits
March 7, 2024 09:24
…ield by adding more enumerations
Author
|
Commands and formatting added. Please provide additional feedback if further changes are needed. |
PhyxionNL
reviewed
Mar 8, 2024
Comment on lines
1
to
7
| /* | ||
| This file is part of PacketDotNet. | ||
|
|
||
| This Source Code Form is subject to the terms of the Mozilla Public | ||
| License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| */ |
Collaborator
There was a problem hiding this comment.
This bit still needs to exists, the lower copyright block doesn't.
Author
|
Anything more I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.