fix multi ticker download when some tickers failed #319
Open
ericwbzhang wants to merge 7 commits intodpguthrie:masterfrom
Open
fix multi ticker download when some tickers failed #319ericwbzhang wants to merge 7 commits intodpguthrie:masterfrom
ericwbzhang wants to merge 7 commits intodpguthrie:masterfrom
Conversation
# Conflicts: # yahooquery/ticker.py # yahooquery/utils/__init__.py
Author
|
@dpguthrie @maread99 it fixes bugs when you download multiple tickers. Please kindly review. |
Collaborator
|
Hi @ericwbzhang, thanks for the PR! Could you please 1) include a test and 2) open an issue which includes an actual example of the issue that this PR is resolving. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The results and tickers are not matched when you download multiple tickers and some return None