Repository navigation
fix: clear stale login error after successful registration - #29
Closed
jehanbheda wants to merge 1 commit into
Closed
jehanbheda wants to merge 1 commit into
jehanbheda wants to merge 1 commit into
Conversation
drakeRAGE
self-requested a review
October 29, 2025 06:54
Owner
|
Hey @jehanbheda, great work on the PR! However, this issue was raised by someone else, so I can’t merge it. Really appreciate the effort ,feel free to pick another issue. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25
This pull request fixes a UI bug where the login error message from a previous failed sign-in attempt persisted even after a successful registration and redirect to the Sign In page.
Changes Made:
Added a clearError reducer in userSlice.jsx to reset authentication errors.
Implemented a useEffect in SignIn.jsx to dispatch clearError() when the component mounts, ensuring the login page always loads in a clean state.
Steps to Verify:
Attempt to sign in with incorrect credentials → observe the error message.
Navigate to the Sign Up page → complete registration successfully.
After redirection to the Sign In page, confirm that the old error message no longer appears.
Result:
The Sign In page now correctly resets its state after a successful registration, improving user experience and reducing confusion.