Skip to content

fix (vibe-kanban)#3

Merged
dreaifekks merged 2 commits into
masterfrom
vk/4f58-fix
Feb 8, 2026
Merged

fix (vibe-kanban)#3
dreaifekks merged 2 commits into
masterfrom
vk/4f58-fix

Conversation

@dreaifekks

Copy link
Copy Markdown

当前订阅没有去重,导致每次都会返回一大串重复的内容,修复一下

@opencode-agent

opencode-agent Bot commented Feb 8, 2026

Copy link
Copy Markdown

Focused on the scheduled feed loop in index.js since that’s where the dedup change lands.

Review

  • The new grouping-by-rssUrl flow is the right direction for reducing repeated fetches and message sends.
  • I see a couple of edge cases that still allow duplicates or skipped posts.

Issues

  • Dedup isn’t actually enforced per chat/thread: if the KV already contains duplicate subscriptions, subscribers will still contain duplicates and the loop will send the same item multiple times. The PR description says duplicates exist; this code doesn’t remove them. Consider deduping subscribers by chatId + threadId (or chatId + threadId + rssUrl) before sending in index.js.
  • sentKey uses a 32‑bit hash of rssUrl in index.js. Hash collisions are rare but possible; a collision would cause feeds to share GUID caches and skip legitimate posts. Using the raw rssUrl (or a stable encoded form) would avoid this.

Notes

  • channelName is taken from subscribers[0] for all subscribers in the group in index.js. If the same rssUrl can have different channelName values, the displayed source will be inconsistent.

Status

  • No tests run (none requested).

If you want, I can propose a minimal patch to dedupe subscribers and make sentKey collision‑safe.

New%20session%20-%202026-02-08T07%3A28%3A15.270Z
opencode session  |  github run

@opencode-agent

opencode-agent Bot commented Feb 8, 2026

Copy link
Copy Markdown

Update looks solid. The scheduled loop now dedupes per chat/thread and uses a collision‑safe sentKey, and message composition uses each subscriber’s channelName. Forwarding and RSSHub URL normalization updates are consistent and improve behavior in index.js.

  • No blocking issues found.
  • Tests not run (not requested).

Approval: ✅

If you want extra coverage, the next natural step is running a quick manual check of /add, /list, /del, and /forward_to flows to confirm the new type labels and forwarding behavior.

New%20session%20-%202026-02-08T07%3A49%3A17.443Z
opencode session  |  github run

@dreaifekks dreaifekks merged commit 893c48c into master Feb 8, 2026
1 check passed
@dreaifekks dreaifekks deleted the vk/4f58-fix branch February 8, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant