Security: fix session leaks, OAuth redirect validation, host header injection#29
Open
nicdavidson wants to merge 4 commits intodevelopfrom
Open
Security: fix session leaks, OAuth redirect validation, host header injection#29nicdavidson wants to merge 4 commits intodevelopfrom
nicdavidson wants to merge 4 commits intodevelopfrom
Conversation
…jection Daemon (server.ts): - Replace wildcard CORS with configurable MCP_CORS_ORIGIN (default localhost:8080) - Remove session ID arrays from /health and /ping responses (use count only) - Add internal API key check to /mcp/cache/clear endpoint PHP middleware (McpStreamMiddleware.php): - Replace wildcard Access-Control-Allow-Origin with app.url config value OAuth controller (McpOAuthController.php): - Validate redirect_uri against client's registered redirect_uris - Replace X-Forwarded-Host trust with APP_URL config to prevent host header injection
MCP clients (Claude Desktop, Cursor, etc.) connect from arbitrary origins. Endpoints are already protected by DreamFactory session tokens. Restrictive CORS would break all external MCP client connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daemon (server.ts)
/healthand/pingresponses (return count only)/mcp/cache/clearendpointPHP middleware (McpStreamMiddleware.php)
*) — MCP clients are inherently externalOAuth controller (McpOAuthController.php)
redirect_uriagainst client's registered redirect URIsX-Forwarded-Hostheader trust withAPP_URLconfig to prevent host header injectionTest plan
tsc --noEmit)php -l)active_sessionscount (not session IDs)