Conversation
Vue 2 does not make properties reactive when added to an already-observed
object via direct assignment. editSettings was declared as {} in data(),
so properties set in resetEditSettings() were invisible to the dependency
tracker — hasChanges never re-evaluated and buttons stayed disabled.
Fix: replace the object wholesale in resetEditSettings() so Vue observes
all properties on the new object, and use this.$set() in resetForm() for
the same reason.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
The Vue 3 SessionList.vue was sending an empty POST body to
/api/v1/show/sessions/start, causing a JSONDecodeError on the server.
The endpoint requires {"session_id": "<uuid>"} to identify the
initiating client, matching the pattern already used by the navbar.
Also removes the unreachable Stop Session button from both the Vue 2
and Vue 3 SessionList components — the START_SHOW WebSocket message
pushes all clients to /live the moment a session starts, making the
button inaccessible. Stop Session remains available via the navbar.
Adds E2E coverage in spec 12 for the sessions tab Start button,
including cleanup via the navbar to leave clean state for spec 13.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
client
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit b021876. ♻️ This comment has been updated with latest results. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit b021876. ♻️ This comment has been updated with latest results. |
|
❌ The last analysis has failed. |
|
Python Test Results 1 files 1 suites 1m 32s ⏱️ Results for commit b021876. |
Playwright E2E Results (chromium)154 tests 154 ✅ 1m 31s ⏱️ Results for commit b021876. |
Playwright E2E Results (firefox)154 tests 154 ✅ 1m 33s ⏱️ Results for commit b021876. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.