Conversation
…1151) * Broadcast SCRIPT_PAGE_CHANGED after script saves so other clients update in real-time When one client saved script changes, other connected clients did not see the updates without a manual refresh. The backend was missing a WebSocket broadcast after the save commit in both the POST and PATCH handlers. Adds ws_send_to_all("NOOP", "SCRIPT_PAGE_CHANGED", {"page": page}) to both handlers, and adds matching action handlers in the Vue 2 Vuex store (SCRIPT_PAGE_CHANGED) and Vue 3 Pinia store (scriptPageChanged) that reload the changed page into both the script store and tmpScript (the data source the editor template renders from) when the page is loaded. Fixes #1149. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Use Object.hasOwn() instead of Object.prototype.hasOwnProperty.call() Addresses SonarCloud warnings on PR #1151. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…r/no-header-close (#1150) (#1152) Bootstrap Vue Next renamed these props from BV2. The old names were silently ignored, causing modal footers and close buttons to remain visible/enabled when they should be hidden (e.g. during an in-progress save). Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
small-diff
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 926354d. ♻️ This comment has been updated with latest results. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 926354d. ♻️ This comment has been updated with latest results. |
|
Python Test Results 1 files 1 suites 1m 43s ⏱️ Results for commit 926354d. |
Playwright E2E Results (chromium)160 tests 160 ✅ 1m 31s ⏱️ Results for commit 926354d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.