Fix cue editor modal interactions in V3 UI#1195
Merged
Merged
Conversation
- Go to Page: Replace Vuelidate with a simple ref + v-model.number, so clicking OK actually navigates instead of silently failing validation - Add New Cue / Edit Cue modals: Wire BForm @submit to the existing handlers so pressing Enter submits the form (was a no-op previously) - Jump to Cue: Move modal.hide() into navigateToMatch() so selecting from a multi-match or suggestion list closes the modal (only the single-match path closed it before) - Add E2E coverage for all three fixes in specs 08 and 10 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 90f413c. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit 90f413c. |
|
Python Test Results 1 files 1 suites 2m 10s ⏱️ Results for commit 90f413c. |
Playwright E2E Results (firefox)180 tests 180 ✅ 1m 53s ⏱️ Results for commit 90f413c. |
Playwright E2E Results (chromium)180 tests 180 ✅ 1m 54s ⏱️ Results for commit 90f413c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refandv-model.number, which works correctly.BForm@submithandler was bound to an empty string, so pressing Enter had no effect. Wired it to the existingonSubmitNew/onSubmitEdithandlers.modal.hide()only ran on the single-exact-match path. Moved it intonavigateToMatch()so selecting from a multi-match list or a fuzzy-suggestion list also closes the modal.Test plan
npm run ci-lint— passes (Prettier + ESLint)npm run typecheck— passesnpm run test:run— 136/136 Vitest tests passnpm run test:e2e— 180/180 Playwright tests pass (Chromium), including new tests in specs 08 and 10🤖 Generated with Claude Code