Skip to content

Conversation

sam-lippert
Copy link
Contributor

Summary

  • implement CLI logic using apis.do client
  • document integrations usage in README

Testing

  • pnpm test (fails: connect ECONNREFUSED)

@Copilot Copilot AI review requested due to automatic review settings May 28, 2025 15:18
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 3:26pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new CLI wrapper around the apis.do client for managing external integrations and documents usage in the README.

  • Implements CLI class with listIntegrations, connect, and disconnect backed by API
  • Updates README to show example calls for listing, connecting, and deleting integrations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdks/integrations.do/src/cli.ts Introduce CLI methods that call API.get/post
README.md Add example usage for the new integrations API
Comments suppressed due to low confidence (4)

sdks/integrations.do/src/cli.ts:10

  • New CLI methods lack accompanying unit tests. Consider adding tests for listIntegrations, connect, and disconnect to ensure correct behavior.
async listIntegrations() {

README.md:85

  • The documentation calls integrations.list(), but the CLI class exposes listIntegrations(). Update the example to match the actual method name or add an alias in the CLI.
const services = await integrations.list()

README.md:88

  • The example passes { type: 'apiKey', apiKey: ... } but connect() only accepts { token?: string }. Align the CLI signature with the documented options or update the example.
const connection = await integrations.connect('github', { type: 'apiKey', apiKey: process.env.GITHUB_TOKEN })

README.md:91

  • The example uses deleteConnection(), but the CLI provides disconnect(). Rename one for consistency or document both aliases.
await integrations.deleteConnection(connection.id)

Copy link
Contributor

📦 Next.js Bundle Analysis for do

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant