Skip to content

Fix: Replace Unsafe Java Deserialization with Jackson Mapper #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simei2k wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix: Replace Unsafe Java Deserialization with Jackson Mapper #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions ...n-starter/sa-token-jboot-plugin/src/main/java/cn/dev33/satoken/jboot/SaJdkSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,18 +55,25 @@ public Object deserialize(byte[] bytes) {
if (bytes == null || bytes.length == 0) {
return null;
}
ObjectInputStream objectInput = null;

ByteArrayInputStream bais = new ByteArrayInputStream(bytes);
try {
ByteArrayInputStream bytesInput = new ByteArrayInputStream(bytes);
objectInput = new ObjectInputStream(bytesInput);
return objectInput.readObject();
}
catch (Exception e) {
// Configure mapper for safe deserialization
mapper.configure(MapperFeature.AUTO_DETECT_FIELDS, true);
mapper.configure(MapperFeature.AUTO_DETECT_SETTERS, true);
mapper.enable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES);

// Use mapper instead of ObjectInputStream
return mapper.readValue(bais, _clazz);
} catch (Exception e) {
LOG.error("Error during deserialization of bytes", e);
throw new RuntimeException(e);
}
finally {
if (objectInput != null)
try {objectInput.close();} catch (Exception e) {LOG.error(e.getMessage(), e);}
} finally {
try {
bais.close();
} catch (Exception e) {
LOG.error(e.getMessage(), e);
}
}
}
}