Skip to content

Conversation

Narendra-Neerukonda
Copy link

@Narendra-Neerukonda Narendra-Neerukonda commented Jun 18, 2021

Filled out the Dropbox Contributor License Agreement
Fixes #392

from past.builtins import basestring
from pyhive import exc
import abc
import collections

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file still uses deque from collections at

self._data = collections.deque()
. This import should not be removed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted to "import collections" and changed import at Iterable statement as collections.abc.Iterable

@Narendra-Neerukonda Narendra-Neerukonda changed the title import iterable from collection.abc instead of collections import iterable from collection.abc instead of collections to clear deprecation warning in python 3.10 Jun 19, 2021
@admackin
Copy link

This PR seems like it would be really handy as it would allow pyhive to be compatible with python 3.10. Any chance of it getting merged?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fabiofalavinha
Copy link

What's the ETA to merge this pull request?

@fabiofalavinha
Copy link

As a workaround, I just added the code on my python script:

if "3.10" in sys.version:
    collections.Iterable = collections.abc.Iterable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing ABC directly from collections has been removed in Python 3.10 in favor of collections.abc

5 participants