Add DownloadResult type to filesDownload method #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

nicomontanari wants to merge 2 commits into dropbox:main from nicomontanari:feature/file-downloading-type

+5 −1

nicomontanari commented Sep 4, 2024

Checklist

General Contributing

Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

Non-code related change (markdown/git settings etc)
SDK Code Change
Example/Test Code Change

Validation

Does npm test pass?
Does npm run build pass?
Does npm run lint pass?


          chore: update types for file download result

12f2d1d

CLAassistant commented Sep 4, 2024 •

edited

Loading

All committers have signed the CLA.

Contributor

greg-db commented Sep 4, 2024

Thanks! I'll ask the team to review this.


          Update fileBinary type

e60569d

toddjudd approved these changes

View reviewed changes

toddjudd left a comment

I'm monkey patching the same for prod. Should just be in the repo by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet