Improve hq.rs #211
Open
Improve hq.rs #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
rework-backrefs
branch
2 times, most recently
from
499dc2a to
0ec80e0
Compare
Attention: there is clearly a bug in the code when it uses `v.wrapping_add(1) > 0` when `v` is a `usize`-- because the only way for this condition to be false is for `v` to be `usize::MAX` -- and this will not be consistent between x32 and x64 versions. Moreover, there is even a case of `wrapping_add(2)` -- which would only pass if the original is `usize::MAX-1`.
Given all this, this expression does not make any sense, and should be replaced with `m.alloc_cell(num_bytes + 2)`:
```rust
if num_bytes + 2 > 0 {
m.alloc_cell(num_bytes + 2)
} else {
AllocF::AllocatedMemory::default()
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked hq.rs to be simpler.
I found what seems like a bug in the code when it uses
v.wrapping_add(1) > 0whenvis ausize-- because the only way for this condition to be false is forvto beusize::MAX-- and this will not be consistent between x32 and x64 versions. Moreover, there is even a case ofwrapping_add(2)-- which would only pass if the original isusize::MAX-1.Given all this, this expression does not make any sense, and should be replaced with
m.alloc_cell(num_bytes + 2):